[Webkit-unassigned] [Bug 85576] [BlackBerry] AutofillManager implementation upstream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85576


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140460|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-05-07 08:00:24 PST ---
(From update of attachment 140460)
View in context: https://bugs.webkit.org/attachment.cgi?id=140460&action=review

This can be cleaned up some more.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:26
> +class String;

Indent here, this is WebKit style.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:31
> +class WebPagePrivate;

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:37
> +class HTMLInputElement;

The whole block in namespace should be indented.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:50
> +    AutofillManager(BlackBerry::WebKit::WebPagePrivate* page):m_webPagePrivate(page), m_element(0) { }

Watch the ':', it should have space characters around it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.