[Webkit-unassigned] [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70304





--- Comment #66 from Dongwoo Joshua Im <dw.im at samsung.com>  2012-05-07 01:25:59 PST ---
(In reply to comment #65)
> (From update of attachment 140485 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140485&action=review
> 
> > LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-image.html:15
> > +<input type="image" id="imageInput" src="resources/green.jpg" style="display:none">
> > +<div id="console"></div>
> > +<script language="JavaScript">
> > +    var e = document.getElementById("imageInput");
> > +    shouldBe('e.width', '0');
> > +    shouldBe('e.height', '0');
> > +    finishJSTest();
> 
> This is a test for *loaded* image.  So the test should be asynchronous and need to wait for image loading.
> 

Then, I will test 'shouldBe' if readyState == 'complete'.

> > LayoutTests/fast/forms/input-width-height-attributes-without-renderer-not-loaded-image.html:20
> > +    var e = document.getElementById("imageSlow");
> > +
> > +    document.onreadystatechange = function() {
> > +        readyState = document.readyState;
> > +        if (readyState == 'complete') {
> > +            finishJSTest();
> > +        } else if (readyState == 'loading' || readyState == 'interactive') {
> > +            shouldBe('e.width', '0');
> > +            shouldBe('e.height', '0');
> 
> This is a test for *not loaded* image.  So we don't need to make this asynchronous.

I did this because I want to make sure to test 'shoudBe' before readyState == 'complete'.

I will fix this what you recommended at the previous comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.