[Webkit-unassigned] [Bug 83889] Crash in WebKit!WebCore::RenderBoxModelObject::paddingLeft+0x5c.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83889





--- Comment #30 from Abhishek Arya <inferno at chromium.org>  2012-05-06 22:25:53 PST ---
(In reply to comment #29)
> (In reply to comment #26)
> > > > 
> > > > I could not reproduce this ref-test failure without your patch. Did it work for you ?.
> > > 
> > > I would like to confirm what happens. Did you mean that my patch causes new failure? 
> > > 
> > > I ran ./webkit/tools/layout_tests/run_webkit_tests.sh --debug scrollbars/scrollbar-percent-padding-crash\* on master branch (I copied the ref-test) and obtained the following:
> > > -----
> > >   scrollbars/scrollbar-percent-padding-crash.html -> unexpected crash
> > > 0 tests ran as expected, 1 didn't:
> > > 
> > > Regressions: Unexpected crashes : (1)
> > >   scrollbars/scrollbar-percent-padding-crash.html = CRASH
> > > -----
> > > 
> > > And after applying the patch, I ran the same command and obtained the following:
> > > -----
> > > All 1 tests ran as expected.
> > > -----
> > 
> > I was testing on webkit mac, looks like this is only reproducible through the chromium pipeline. I was able to reproduce this on chromium linux. Btw Julien's trick of dumpAsText(true) works and it does cause the crash. dumpAsText(true) triggers the pixel result generation, keeping the result as still text. e.g. http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/LayoutTests/css3/flexbox/repaint.html&exact_package=chromium&q=%22dumpAstext(true%22&type=cs&l=44. you don't need a ref test.
> > 
> > void LayoutTestController::dumpAsText(const CppArgumentList& arguments, CppVariant* result)
> > {
> >     m_dumpAsText = true;
> >     m_generatePixelResults = false;
> > 
> >     // Optional paramater, describing whether it's allowed to dump pixel results in dumpAsText mode.
> >     if (arguments.size() > 0 && arguments[0].isBool())
> >         m_generatePixelResults = arguments[0].value.boolValue;
> > 
> >     result->setNull();
> > }
> 
> Thank you for information.
> 
> I looked at repaint.html, tested dumpAsText(true) and found that dumpAsText(true) requires a PNG image used as an expected result. I'm afraid that adding an expected image is too much for testing this issue.
> However I found that layoutTestController.display() can invoke the method: WebCore::RenderScrollbarPart::paintIntoRect(). So I modified the test in the following way:
> - added layoutTestController.dumpAsText() and layoutTestController.display(), and
> - added *-expected.txt and removed *-expected.html.
> 
> Does this look ok?  Or is it better to add an expected PNG image?

This looks ok. With the PNG, it will make the results platform specific, and we don't need it in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.