[Webkit-unassigned] [Bug 85032] [EFL][DRT] EFL's DRT does not fully support page visibility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85032





--- Comment #3 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-06 18:48:57 PST ---
(From update of attachment 139779)
View in context: https://bugs.webkit.org/attachment.cgi?id=139779&action=review

> Tools/ChangeLog:8
> +        Implement page visibility API support in EFL's DRT.

This is a very laconic description :-) Not only do you plug the EFL bits, but you also fix the argumentCount check in LTC and add stubs to the other ports' LTCs, so a better description (either here or in the method list below) would be very welcome.

> Tools/DumpRenderTree/LayoutTestController.cpp:1746
>      // Has mac & windows implementation

I think this comment can go away too.

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:902
> +    // FIXME: implement.

We generally add a notImplemented() call instead (this applies to all the other FIXME comments).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.