[Webkit-unassigned] [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84435





--- Comment #12 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-06 18:35:50 PST ---
(In reply to comment #10)
> So I believe that even if we removed the main_frame check in the EFL port, we would still send the "icon,received" signal for the main frame only.
> 
> Now, I don't know if dispatchDidChangeIcons() is called for the main frame only or not but does it really make sense to emit the "icon,changed" signal potentially for all frame when we know for sure that we send the "icon,received" signal only for the main frame?

Nope, we should either send both signals in all cases or only for the main frame. It'd be nice if you could check whether the WebCore machinery that ends up in our FrameLoaderClient also makes this distinction between main frames and other frames or not -- from an API user point of view, it makes sense to provide as much information as possible (ie. if all frames have favicons, they should all be available for the user to query).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.