[Webkit-unassigned] [Bug 78559] [EFL][DRT] Implement TextInputController.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78559





--- Comment #15 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-06 18:30:46 PST ---
(From update of attachment 139335)
View in context: https://bugs.webkit.org/attachment.cgi?id=139335&action=review

I can't help much here because text editing is not an area I'm familiar with, and most of the patch seems to be common, boilerplate code. It'd be good if some reviewer who works on editing stuff could take a look at this before landing.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:623
> +    String compositionString = String::fromUTF8(text);

Could be const.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:629
> +bool DumpRenderTreeSupportEfl::hasComposition(Evas_Object* ewkView)

ewkView, page and editor can be const in this method.

> Tools/DumpRenderTree/efl/TextInputController.h:28
> +#ifndef TextInputController_h

Nit: we generally separate the copyright header from the ifdef guards with an empty line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.