[Webkit-unassigned] [Bug 78559] [EFL][DRT] Implement TextInputController.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78559





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-06 18:05:37 PST ---
(From update of attachment 139335)
View in context: https://bugs.webkit.org/attachment.cgi?id=139335&action=review

Basically, this patch move GTK's implementation to EFL port. So, it seems to me there is no critical issue.

> LayoutTests/ChangeLog:8
> +        Implemented textInputController for EFL DRT.

I think this is unsufficient description for this patch.

> Source/WebKit/efl/ChangeLog:8
> +        Implemented textInputController for EFL DRT.

ditto.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:643
> +{

Is it better to initialize start and length like gtk port ? I think we need to initialize start and length.

http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp#L478

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:670
> +    }

Nit : Add an empty line to here.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:698
> +{

Add a condition to check if start and length variables are 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.