[Webkit-unassigned] [Bug 85598] Share stylesheet data structures between documents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85598





--- Comment #13 from Darin Adler <darin at apple.com>  2012-05-06 16:53:37 PST ---
(In reply to comment #12)
> If the idea is to always redefine ExceptionCode in the header, why is it defined in ExceptionCode.h at all?

The design has been to use typedef int ExceptionCode in files that need only the type, and ExceptionCode.h in files that need constants for DOM exception codes. Analogous to using class Node when we need only the class, and Node.h when we need to call functions on an object. We have about a hundred different headers that do the "typedef int ExceptionCode" thing and about two hundred more that use ExceptionCode.h.

I’m not married to it. We could change the design. But that’s how it’s been for a long time, and I don’t think we should start moving away from the typedef as we are making other changes to a header unless we make a conscious decision to do so across the project.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.