[Webkit-unassigned] [Bug 85752] Truncating multiplication on integers should not OSR exit every time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85752





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2012-05-06 16:30:14 PST ---
(In reply to comment #2)
> (From update of attachment 140441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=140441&action=review
> 
> r-, because I really do think we need a comment here – but nice optimization, looks great otherwise.
> 
> > Source/JavaScriptCore/dfg/DFGGraph.h:512
> > +        int32_t twoToThe17 = 131072;
> 
> Why 2^17?

Yeah, that's sloppy.  It was the largest I tested and I figured it was good enough for the optimization to be effective.  I will make this more rational!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.