[Webkit-unassigned] [Bug 85721] DFG should support reflective arguments access

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 6 11:59:48 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85721


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver at apple.com




--- Comment #6 from Oliver Hunt <oliver at apple.com>  2012-05-06 11:59:47 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 140415 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=140415&action=review
> > 
> > > Source/JavaScriptCore/runtime/Arguments.h:53
> > > -        bool overrodeLength : 1;
> > > +        bool overrodeLength; // make this a full byte to make it easy to test from the JIT.
> > >          bool overrodeCallee : 1;
> > >          bool overrodeCaller : 1;
> > >          bool isStrictMode : 1;
> > 
> > Is keeping the rest of these bit fields actually saving space?
> 
> Good point. I will change.

It occurs to me that the dfg uses a structure check for arguments -- what happens if we made overriding the length change the structure -> then we'd just have the single structure check and all would be well.  Not suggesting that change for this patch though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list