[Webkit-unassigned] [Bug 85711] Web Inspector: Turn HelpScreen to be View.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 5 08:31:37 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=85711
Pavel Feldman <pfeldman at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #140400|review? |review-
Flag| |
--- Comment #2 from Pavel Feldman <pfeldman at chromium.org> 2012-05-05 08:31:37 PST ---
(From update of attachment 140400)
View in context: https://bugs.webkit.org/attachment.cgi?id=140400&action=review
Overall looks good. Note that since you are going to make it tabbed pane, you will not need the custom show / hide logic - your help screen will become singleton. So most of the code here will vanish.
> Source/WebCore/inspector/front-end/HelpScreen.js:68
> show: function(onHide)
Do we actually use onHide?
> Source/WebCore/inspector/front-end/HelpScreen.js:-62
> - if (this._isShown)
You are overriding View's show with different parameters. I would pick another name.
> Source/WebCore/inspector/front-end/HelpScreen.js:70
> + var visibleHelpScreen = WebInspector.HelpScreen.visibleScreen_;
_ is before the name, not after
> Source/WebCore/inspector/front-end/HelpScreen.js:79
> + WebInspector.View.prototype.show.call(this, document.body);
document.body -> WebInspector.inspectorView.element
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list