[Webkit-unassigned] [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85624





--- Comment #6 from eustas.bug at gmail.com  2012-05-05 04:58:01 PST ---
(From update of attachment 140233)
View in context: https://bugs.webkit.org/attachment.cgi?id=140233&action=review

>> Source/WebCore/ChangeLog:8
>> +        Append record to timeline when drawing on HTML Canvas causes invalidation,
> 
> Do you want a stack that caused repaint here? Why are you only interested in canvas invalidations?

Stack is captured as well.

>> Source/WebCore/html/HTMLCanvasElement.cpp:232
>> +        InspectorInstrumentation::didInvalidateRect(this->document(), dirtyRect);
> 
> This is only a fraction of invalidations, a more specific name is needed. Also, why do we want to instrument invalidation? Are you trying to trace the subsequent paint from InspectorInstrumentation::willPaint to it?

Renamed to didInvalidateCanvasRect.
We want to instrument invalidation to show to user code point that initiated deferred painting.
Currently we do not link invalidation with subsequent painting.

>> Source/WebCore/inspector/front-end/TimelineModel.js:82
>> +    InvalidateRect: "InvalidateRect"
> 
> That's what is making the test fail, you should update the test.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.