[Webkit-unassigned] [Bug 85624] Web Inspector: HTMLCanvasElement::didDraw instrumentation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85624


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140233|review?                     |review-
               Flag|                            |




--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2012-05-04 22:56:14 PST ---
(From update of attachment 140233)
View in context: https://bugs.webkit.org/attachment.cgi?id=140233&action=review

> Source/WebCore/ChangeLog:8
> +        Append record to timeline when drawing on HTML Canvas causes invalidation,

Do you want a stack that caused repaint here? Why are you only interested in canvas invalidations?

> Source/WebCore/html/HTMLCanvasElement.cpp:232
> +        InspectorInstrumentation::didInvalidateRect(this->document(), dirtyRect);

This is only a fraction of invalidations, a more specific name is needed. Also, why do we want to instrument invalidation? Are you trying to trace the subsequent paint from InspectorInstrumentation::willPaint to it?

> Source/WebCore/inspector/front-end/TimelineModel.js:82
> +    InvalidateRect: "InvalidateRect"

That's what is making the test fail, you should update the test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.