[Webkit-unassigned] [Bug 84214] [BlackBerry] Loading media data with http authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84214


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138047|review?                     |review-
               Flag|                            |




--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2012-05-04 13:24:59 PST ---
(From update of attachment 138047)
View in context: https://bugs.webkit.org/attachment.cgi?id=138047&action=review

Still some stuff to clean up.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:663
> +ProtectionSpace generateProtectionSpaceFromMMRAuthChallenge(const MMRAuthChallenge& authChallenge)

Should be static.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:667
> +        return ProtectionSpace();

Better maybe ASSERT(url.isValid()); since the call sites already check it, so it should not happen.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:691
> +    }

How about this? :

if (credential.isEmpty()) {
 if (frameView() && frameView()->hostWindow())
     isConfirmed = frameView()->hostWindow()->platformPageClient()->authenticationChallenge(url, protectionSpace, credential);
} else
    isConfirmed = true;

if (isConfirmed)
    authChallenge.setCredential(credential.user().utf8().data(), credential.password().utf8().data(), static_cast<MMRAuthChallenge::CredentialPersistence>(credential.persistence()));

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:134
> +    virtual void onAuthenticationAccepted(const BlackBerry::Platform::MMRAuthChallenge&);

Can these be const?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.