[Webkit-unassigned] [Bug 85253] Apply animations and transitions for first-letter element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85253


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140139|review?                     |review-
               Flag|                            |




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-05-04 10:49:47 PST ---
(From update of attachment 140139)
View in context: https://bugs.webkit.org/attachment.cgi?id=140139&action=review

Tests still need to be improved.

> LayoutTests/animations/first-letter-animation.html:13
> +    .box {
> +      position: relative;
> +      left: 400px;
> +      top: 100px;
> +      width: 100px;
> +      height: 100px;
> +      background: blue;
> +      -webkit-animation: boxAnim 1s linear;

A one second test is way too slow. Can this test be changed to use the pauseAPI? (though that might need fixing for pseudos).

> LayoutTests/animations/first-letter-animation.html:29
> +    @-webkit-keyframes firstLetterAnim {
> +      from { margin: 0px; }
> +      to { margin: 100px; }
> +    }
> +
> +    @-webkit-keyframes boxAnim {
> +      from { -webkit-transform: scale(1); }
> +      to { -webkit-transform: scale(3); }

The interesting case is the same property being animated (in different ways) on the element and the pseudo, but you're not testing that here.

You should also test that setting animation-play-state affects the correct animation.

> LayoutTests/transitions/first-letter-color-transition.html:15
> +      -webkit-transition: color 1s;

Ditto.

> LayoutTests/transitions/first-letter-transition.html:23
> +      -webkit-transition: color 1s;
> +    }
> +
> +    #first {
> +      -webkit-transition: left 1s;
> +    }
> +
> +    #second {
> +      -webkit-transition: color 1s;

This test is also way too slow. Can it use the transition-test-helpers.js?

You also need to test a transition of the same property on the element and the pseudo, preferably where the transitions begin at different times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.