[Webkit-unassigned] [Bug 85478] [Qt] Buildfix for newer Qt5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 4 07:39:08 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=85478
--- Comment #8 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-05-04 07:39:08 PST ---
Attachment 140223 did not pass style-queue:
Source/WebCore/bridge/qt/qt_runtime.cpp:1785: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1792: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1793: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1798: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1808: Declaration has space between type name and * in QtConnectionObject *_t [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1811: Semicolon defining empty statement. Use { } instead. [whitespace/semicolon] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:55: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:72: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:73: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:76: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:78: Missing space before { [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:78: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:79: Missing space before { [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:79: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:147: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:158: Declaration has space between type name and * in JSObject *object [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:159: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:159: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:236: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:235: Missing space before ( in switch( [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:288: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:342: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:363: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:437: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:599: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:623: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:626: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:633: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:647: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:650: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:656: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:660: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:666: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:665: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:772: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:775: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:818: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:819: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:820: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:821: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:831: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:832: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:833: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:834: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:835: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:836: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:837: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:838: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:839: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:857: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:858: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:862: Missing space after , [whitespace/comma] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:935: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:967: Missing space after , [whitespace/comma] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1020: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1057: More than one command on the same line [whitespace/newline] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1089: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1097: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1114: Missing spaces around = [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1132: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1184: Missing space before ( in foreach( [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1193: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1198: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1219: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1222: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1281: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1280: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1289: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1297: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1302: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1308: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1371: Missing spaces around = [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1433: Declaration has space between type name and * in QObject *obj [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1436: Declaration has space between type name and * in void *qargs [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1452: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1467: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1592: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1602: Declaration has spFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
ace between type name and * in JSObject *asObj [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1619: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1620: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1627: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1633: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1656: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1649: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1669: Missing space before ( in foreach( [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1696: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1773: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1774: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1780: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1783: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1800: Declaration has space between type name and * in void *QtConnectionObject [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1802: More than one command on the same line in if [whitespace/parens] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1809: _c is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1809: _id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1894: Extra space before ( in function call [whitespace/parens] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1913: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 100 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list