[Webkit-unassigned] [Bug 85571] New: Convert setDefersLoading to use InternalSettings interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85571

           Summary: Convert setDefersLoading to use InternalSettings
                    interface
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung.kim at samsung.com
                CC: ap at webkit.org


Adjust setDefersLoading tests to use InternalSettings instead of LayoutTestController interface. In my opinion, setDeferLoading() is able to be supported by InternalSettings because this feature just enables/disables defer loading feature in page settings. In addition, this feature is implemented by DumpRenderTreeSupportXXX of ports instead of public APIs.


For example, in Qt port case,

void LayoutTestController::setDefersLoading(bool flag)
{
    DumpRenderTreeSupportQt::setDefersLoading(m_drt->webPage(), flag);
}


void DumpRenderTreeSupportQt::setDefersLoading(QWebPage* page, bool flag)
{
    Page* corePage = QWebPagePrivate::core(page);
    if (corePage)
        corePage->setDefersLoading(flag);
}

Hello  Alexey, I would like to know how do you think about this ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.