[Webkit-unassigned] [Bug 85425] Use suitable viewport values when a Mobile DTD is used.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85425





--- Comment #13 from Hugo Parente Lima <hugo.lima at openbossa.org>  2012-05-03 10:23:21 PST ---
(In reply to comment #8)
> (From update of attachment 139892 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139892&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Set the viewport width to device-width when the document uses a mobile DTD.
> 
> What is the definition of that? XHTML-MP?
> 
> > Source/WebCore/html/parser/HTMLConstructionSite.cpp:244
> > +    if (doctype->publicId().contains("Mobile"))
> 
> I would be a lot more specific here. Did you look at how we did this for the N9? It doesn't seem so given Zalan's comments.

I agree this check is too weak, but I can do the check against all possibilities:

"-//WAPFORUM//DTD XHTML Mobile 1.0//EN"
"-//WAPFORUM//DTD XHTML Mobile 1.1//EN"
"-//WAPFORUM//DTD XHTML Mobile 1.2//EN"

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.