[Webkit-unassigned] [Bug 85388] Bugs in WebFullScreenController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85388





--- Comment #4 from Jer Noble <jer.noble at apple.com>  2012-05-03 08:47:45 PST ---
(From update of attachment 139839)
View in context: https://bugs.webkit.org/attachment.cgi?id=139839&action=review

> tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:375
>      // If the user has moved the fullScreen window into a new space, temporarily change
>      // the collectionBehavior of the webView's window so that it is pulled into the active space:
> -    if (![webWindow isOnActiveSpace]) {
> +    if (!([webWindow respondsToSelector:@selector(isOnActiveSpace)] ? [webWindow isOnActiveSpace] : YES)) {
>          NSWindowCollectionBehavior behavior = [webWindow collectionBehavior];
>          [webWindow setCollectionBehavior:NSWindowCollectionBehaviorCanJoinAllSpaces];
>          [webWindow orderWindow:NSWindowBelow relativeTo:[[self window] windowNumber]];

This looks good.

> tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:477
> -        SetSystemUIMode(_isFullScreen ? kUIModeNormal : kUIModeAllHidden, 0);
> +        SetSystemUIMode(_isFullScreen ? kUIModeAllHidden : kUIModeNormal, 0);

Whoops.  Good catch here too.

> tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:496
> -    [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:otherView];
> -    [otherView removeFromSuperview];
> +    [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:view];
> +    [view removeFromSuperview];

This got fixed in http://trac.webkit.org/changeset/115368 and http://trac.webkit.org/changeset/115324.

It would be pretty simple to write up a ChangeLog entry for these two changes.  I don't believe you will need a test case, as DumpRenderTree and WebKitTestRunner never hit this code; (they do their own pseudo-full screen).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.