[Webkit-unassigned] [Bug 84941] [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84941


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139438|0                           |1
        is obsolete|                            |
 Attachment #139438|review?, commit-queue?      |
               Flag|                            |
 Attachment #139956|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Christophe Dumez <christophe.dumez at intel.com>  2012-05-02 22:49:11 PST ---
Created an attachment (id=139956)
 --> (https://bugs.webkit.org/attachment.cgi?id=139956&action=review)
Patch

I have fixed the Changelog.

Note - however - that I did not change the type of mime_type struct member:
- The url member in the same struct cannot be changed either and is "const char *". Unlike the request struct, the response one cannot be changed at all.
- If I change to "const char * const", then this means I need to initialize it as soon as I create the struct (which is a bit inconvenient). The following code wouldn't work anymore:

Ewk_Frame_Resource_Response* redirectResponse;
    Ewk_Frame_Resource_Response responseBuffer;
    CString redirectUrl, mimeType;

    if (coreResponse.isNull())
        redirectResponse = 0;
    else {
        redirectUrl = coreResponse.url().string().utf8();
        mimeType = coreResponse.mimeType().utf8();
        responseBuffer.url = redirectUrl.data();
        responseBuffer.status_code = coreResponse.httpStatusCode();
        responseBuffer.mime_type = mimeType.data();
        redirectResponse = &responseBuffer;
    }

    Ewk_Frame_Resource_Messages messages = { &request, redirectResponse };

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.