[Webkit-unassigned] [Bug 81560] webkitpy: platforminfo should replace direct checks for sys.platform wherever possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81560





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-02 14:04:30 PST ---
Not right now, really. What I've been doing these days is:

 1. Try to clean up some uses of sys.platform
 2. Convert checks for "darwin" to PlatformInfo.is_mac(), then do the same for PlatformInfo.is_win()
 3. Add is_win32() and is_cygwin() to PlatformInfo and make is_win() return `self.is_win32() or self.is_cygwin()'.

After that comes the tricky part of replacing the pieces of code which only check for "cygwin" or "win32" -- I'm not sure how to approach this, but when we talked on IRC about this issue (it all started because I'd like webkitpy to support FreeBSD and the current approach in bug 81467 is too intrusive) we thought of adding some kind of "is_unix" or "is_nix" to PlatformInfo. Right now I'm considering making this method just return something like `is_linux() or is_foo() or is_bar()', but this is where feature checks would come handy as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.