[Webkit-unassigned] [Bug 85416] New: Environment variables can break build script

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85416

           Summary: Environment variables can break build script
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Minor
          Priority: P3
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dominich at chromium.org


Created an attachment (id=139874)
 --> (https://bugs.webkit.org/attachment.cgi?id=139874&action=review)
Patch with proposed solution

On Mac, there is a script named check_objc_rename.sh that relies on multiple grep commands piping output into one another. If the user has something like GREP_OPTIONS=--color=always, this will break and the build will fail with an unexpected error regarding violations of the renaming policy.

One option to fix this is to clear the GREP_OPTIONS env var specifically from the script. A more concrete solution would be to add something like the following to ensure the script is running in a clean environment:

if [ "${WEBKIT_CLEAN_ENVIRONMENT:-no}" = "no" ]; then
  exec env -i WEBKIT_CLEAN_ENVIRONMENT=yes \
    PATH="$PATH" \
    <... other env vars...>
    bash "$0" "$@"
fi

I've attached a patch for the latter option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.