[Webkit-unassigned] [Bug 85388] New: Bugs in WebFullScreenController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85388

           Summary: Bugs in WebFullScreenController
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.7
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tobias.netzel at googlemail.com


I run a project to maintain WebKit compatible with OS X 10.5 PowerPC (http://code.google.com/p/leopard-webkit).

While fixing the W3C fullscreen API support to work on said target platform I found out that actually there are some bugs in WebFullScreenController that actually happen to not affect more recent versions of Mac OS X. Nevertheless I'm quite sure they are coding errors.

The first difference in the attached patch file should only affect 10.5 but I included it because it improves consistency with other parts of WebFullScreenController.
The second one also affects 10.5 only but is an error that should be corrected (probably WebFullScreenController has never been tested on 10.5).

The last difference is the most important one as in my opinion the original source code is clearly buggy here but nevertheless seems to work on recent versions of OS X.

I would be glad if someone could take the patch through the reviewing process into the repository.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.