[Webkit-unassigned] [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75825


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138335|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2012-05-02 09:37:16 PST ---
(From update of attachment 138335)
View in context: https://bugs.webkit.org/attachment.cgi?id=138335&action=review

I took a quick look.  One note below.  Ideally Eric or Dirk would review your patch.

> Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:43
> +            detector = SCMDetector(self._fs, Executive()).detect_scm_system(self._fs.getcwd())

We should get the Executive from the tool so that it gets mocked properly during testing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.