[Webkit-unassigned] [Bug 85089] [Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85089


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139254|review?                     |review-
               Flag|                            |




--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2012-05-02 03:28:53 PST ---
(From update of attachment 139254)
View in context: https://bugs.webkit.org/attachment.cgi?id=139254&action=review

I think the patch is correct, but at the same time I think a layout test should cover this. It might be that there is already one, in which case this should be mentioned in the ChangeLog.

> Source/WebCore/ChangeLog:11
> +        No new tests.

Well, shouldn't there be one then? :) It doesn't sound difficult to create a layout test that triggers the assert in a debug build.

>> Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp:77
>> +        delete data;
> 
> Maybe we could avoid allocating and de-allocating memory for a FontCustomPlatformData instance altogether in that case by creating a temporary QRawFont instance on the stack before that and doing the load / check there.
> If it's valid, the implicit sharing makes copying it to the newly created FontCustomPlatformData almost free anyway.

I agree with Pierre. Either a temporary QRawFont object or putting FontCustomPlatformData into an OwnPtr that is leaked() on return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.