[Webkit-unassigned] [Bug 85089] [Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85089





--- Comment #2 from Pierre Rossi <pierre.rossi at gmail.com>  2012-05-02 02:16:30 PST ---
(From update of attachment 139254)
View in context: https://bugs.webkit.org/attachment.cgi?id=139254&action=review

Oh, and it looks like this would allow removing fast/css/font-face-download-error.html from the Skipped list, which is very nice indeed. :)

> Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp:77
> +        delete data;

Maybe we could avoid allocating and de-allocating memory for a FontCustomPlatformData instance altogether in that case by creating a temporary QRawFont instance on the stack before that and doing the load / check there.
If it's valid, the implicit sharing makes copying it to the newly created FontCustomPlatformData almost free anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.