[Webkit-unassigned] [Bug 83889] Crash in WebKit!WebCore::RenderBoxModelObject::paddingLeft+0x5c.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83889





--- Comment #25 from Takashi Sakamoto <tasak at google.com>  2012-05-02 01:44:58 PST ---
(In reply to comment #22)
> (From update of attachment 139602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139602&action=review
> 
> The code change is fine.
> 
> >> LayoutTests/scrollbars/scrollbar-percent-padding-crash.html:1
> >> +<style>
> > 
> > I could not reproduce this ref-test failure without your patch. Did it work for you ?.
> 
> For the record, I don't really like a ref-test that is really not one. Have the 2 files (test & reference) be exactly the same doesn't make a good ref-test as any change would still make the test pass. This should be a dumpAsText(true) output as it would at least catch up variation on the pixel output. If that makes the output platform specific, we may need to find another way.

I would like to use dumpAsText. However I don't know how to enable both dumpPixels and dumpAsText. To reproduce the crash, I think, "dumpPixels" is needed.
The following is a DumpRenderTree's crash log:
-----
crash log for DumpRenderTree (pid 27006):
STDOUT: <empty>
STDERR: [27006:27006:105850062961:ERROR:process_util_posix.cc(143)] Received signal 11
STDERR:     base::debug::StackTrace::StackTrace() [0x86d2aa]
STDERR:     base::(anonymous namespace)::StackDumpSignalHandler() [0x82dec9]
STDERR:     0x7f57dd470af0
STDERR:     WebCore::RenderBoxModelObject::computedCSSPaddingLeft() [0x194088a]
STDERR:     WebCore::RenderBoxModelObject::paddingLeft() [0x106ed72]
.... snip ....
STDERR:     WebKit::WebViewImpl::paint() [0x4d0d62]
STDERR:     WebViewHost::paintRect() [0x481215]
STDERR:     WebViewHost::paintInvalidatedRegion() [0x48149c]
STDERR:     TestShell::dump() [0x46cec0]
STDERR:     TestShell::testFinished() [0x46b6ca]
STDERR:     LayoutTestController::WorkQueue::processWorkSoon() [0x44a9c0]
STDERR:     LayoutTestController::locationChangeDone() [0x44bef1]
STDERR:     WebViewHost::locationChangeDone() [0x480708]
STDERR:     WebViewHost::didFinishLoad() [0x47d986]
-----

The "m_webViewHost->paintInvalidatedRegion();" is invoked only when m_params.dumpPixels && shouldGeneratePixelResults. To enable dumpPixels, I don't know any other way except to use ref-test, i.e. imagediff. 

I would like to ask your idea.

> 
> > LayoutTests/scrollbars/scrollbar-percent-padding-crash.html:13
> > +</script>
> > +<div style="height: 1000px;">
> 
> Test *should* have the following information:
> * bug title
> * bug id or URL (I prefer URL in a clickable format)
> * explain what they expect
> 
> Without those information, the test is at most ambiguous and it will be difficult for any maintainer to know what is expected and if any variation is expected.

I see. I added.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.