[Webkit-unassigned] [Bug 85171] [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85171





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-01 18:46:03 PST ---
(From update of attachment 139422)
View in context: https://bugs.webkit.org/attachment.cgi?id=139422&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:395
> +

Unneeded line.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:666
> +static gboolean booleanFromValue(JSStringRef value)

Do not use unneeded glib type for efl port.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:677
> +    else

If there is no logic when keyString is not "WebKitLoadSiteIconKey", is it better to do nothing until we support other keyStrings ? 

I don't see below code in webkit yet.
else
   notImplemented();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.