[Webkit-unassigned] [Bug 85303] Tests overflow LayoutUnits in rendering code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 15:24:07 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85303





--- Comment #8 from Levi Weintraub <leviw at chromium.org>  2012-05-01 15:24:07 PST ---
(In reply to comment #7)
> ASSERTS are used for programming errors.  So if its a programming error to overflow these, then we should leave the asserts in.  If not, then we should find some other way to handle this. :)
> 
> It sounds like you're saying its a programming error to not check for overflow, if so, it should be simple to fix these tests, no?

Well they're not all programming errors, so I guess asserting is incorrect behavior. How can we avoid dropping this information on the floor for WK Devs? My first reaction is a log message to STDERR (on debug builds only, of course), but right now WebKit is graciously quiet there, and I wouldn't really want to start us down the slippery slope of noise. Suggestions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list