[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #37 from Kihong Kwon <kihong.kwon at samsung.com>  2012-05-01 00:22:30 PST ---
(From update of attachment 137665)
View in context: https://bugs.webkit.org/attachment.cgi?id=137665&action=review

>>>> Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.h:49
>>>> +    static void getBatteryStatus(void* data, void* replyData, DBusError*);
>>> 
>>> Is it really necessary to set as public ? It looks this functions are only used by BatteryClientEfl internally.
>>> 
>>> Generally, WebKit doesn't have get prefix. See also : http://www.webkit.org/coding/coding-style.html
>> 
>> Isn't it the opposite?
>> 
>> http://www.webkit.org/coding/coding-style.html#names-setter-getter
> 
> Oops, I'm sorry. I had a confusion. In this case, get prefix is needed.

You are right.
These functions(getBatteryStatus() and setBatteryClient()) can be moved to private.
I will fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.