[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #18 from Vitaly Buka <vitalybuka at chromium.org>  2012-05-01 00:18:13 PST ---
(In reply to comment #8)
> > If frame is NULL than "if" on line 651 will fail and program will not go to 652
> > If you like I can unroll that too to make it more readable.
> 
> Ugh. You're right, but this is a very unusual idiom.
> 
> Anyway, this is a wrong place to add this check. A function named "printing()" should tell whether we're printing, not make guesses about how the result will be used, returning a well-intentioned lie. You should either put the check in a different place, or rename the function to reflect what it's actually returning.
> 
> Eric, I think that you recently mentioned that PDF expected results don't work, because they are machine specific. Could you please comment on whether this is one of those cases?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.