[Webkit-unassigned] [Bug 85267] New: NRWT with --leaks shows leaks from old runs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85267

           Summary: NRWT with --leaks shows leaks from old runs
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: timothy_horton at apple.com
                CC: slewis at apple.com, dpranke at chromium.org


Created an attachment (id=139589)
 --> (https://bugs.webkit.org/attachment.cgi?id=139589&action=review)
patch

A note from webkitpy/layout_tests/port/mac.py:

# FIXME: This will include too many leaks in subsequent runs until the results directory is cleared!

This is indeed the case, and it caught me up earlier today. Seems pretty unfortunate.

I hacked up a horrible solution, which is basically just shoving a UUID through everywhere and using that in the leaks filename. I don't like it, I'm hoping dpranke or someone who knows the code better can come up with something better (I'm happy to implement it, I just need a better idea). (for one: why don't we just capture the output and fling it back through to the manager (can we go in that direction?), and have it all written out into one file per run; that way they'd all be together and not get mixed up).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.