[Webkit-unassigned] [Bug 74409] [GTK] plugins/netscape-plugin-page-cache-works.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74409


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129894|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2012-03-02 08:38:12 PST ---
(From update of attachment 129894)
View in context: https://bugs.webkit.org/attachment.cgi?id=129894&action=review

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:841
>          return;
> +    } else if (g_str_equal(originalName.get(), "WebKitPageCacheSupportsPluginsPreferenceKey")) {
> +        DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins(webkit_web_frame_get_web_view(mainFrame), !g_ascii_strcasecmp(valueAsString.get(), "true") || !g_ascii_strcasecmp(valueAsString.get(), "1"));
> +        return;

Please turn !g_ascii_strcasecmp(valueAsString.get(), "true") || !g_ascii_strcasecmp(valueAsString.get() into a helper function, now that it's repeated three times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.