[Webkit-unassigned] [Bug 82823] [WebSocket]Browser should have platform-specific limitations regarding the frame size

Sat Mar 31 11:21:11 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=82823

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134944|review?                     |review-
               Flag|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2012-03-31 11:21:10 PST ---
(From update of attachment 134944)
View in context: https://bugs.webkit.org/attachment.cgi?id=134944&action=review

> Source/WebCore/ChangeLog:9
> +        Protect browser against exhausting its memory, when it reecives a very big Frame(e.g., of size 2**60).

Typo: reecives.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:87
> +// FIXME: frameSizeLimitation should be platform-specific
> +const size_t frameSizeLimitation = 500 * 1024 * 1024;

This needs an explanation of how each platform would choose the limit. It's not even clear why a hardcoded limit is appropriate. How was this value chosen, for example?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.