[Webkit-unassigned] [Bug 82832] CSSStyleRules should own their CSSStyleDeclarations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82832


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134961|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <kling at webkit.org>  2012-03-31 10:18:06 PST ---
(From update of attachment 134961)
View in context: https://bugs.webkit.org/attachment.cgi?id=134961&action=review

r=me with some sherlocking.

> Source/WebCore/css/PropertySetCSSStyleDeclaration.h:93
> +    ~StyleRuleCSSStyleDeclaration();

Should be marked virtual.

> Source/WebCore/css/PropertySetCSSStyleDeclaration.h:97
> +    virtual CSSRule* parentRule() const { return m_parentRule;  }
>      virtual void setNeedsStyleRecalc();
>      virtual CSSStyleSheet* contextStyleSheet() const;

We're missing some OVERRIDE decorations here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.