[Webkit-unassigned] [Bug 78193] Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78193





--- Comment #5 from yi shen <yi.4.shen at nokia.com>  2012-03-30 13:50:40 PST ---
Thanks for the review. I was thinking to adjust position in ReplaceSectionCommand also. Will try it on my next patch.

(In reply to comment #4)
> (From update of attachment 134857 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134857&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work
> 
> Bug title should appear before the bug url.
> 
> > Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:232
> >              // We can get here if we pasted a copied portion of a blockquote with a newline at the end and are trying to paste it
> >              // into an unquoted area. We then don't want the newline within the blockquote or else it will also be quoted.
> > -            if (Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote))
> > -                startBlock = static_cast<Element*>(highestBlockquote);
> > +            if (m_pasteBlockqutoeIntoUnquotedArea)
> > +                if (Node* highestBlockquote = highestEnclosingNodeOfType(canonicalPos, &isMailBlockquote))
> > +                    startBlock = static_cast<Element*>(highestBlockquote);
> 
> This looks like a hack, and we're adding more hack on top of it. Can we adjust position in ReplaceSelectionCommand to avoid this hack altogether?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.