[Webkit-unassigned] [Bug 82719] Make garden-o-matic, rebaseline-server, TestFailures gardening tools QtWebKit friendly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82719





--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2012-03-30 13:44:31 PST ---
I really support making this happen! Happy to do reviews for this.

(In reply to comment #1)
> It's certainly possible, but it's some amount of work.  We'll need to teach garden-o-matic that bots can exist on multiple servers.  It might be easier to have a different builders.js file for the different masters and have the UI display information from one master at a time.

I was thinking it would make more sense to split it up by platform. Maybe something like this: Apple, GTK, Qt, Chromium. The first three would grab data from build.webkit.org and the Chromium one would do what garden-o-matic currently does (i.e. grab data off build.chromium.org).

It's hard for me to decide whether that's better or whether splitting it up by master is better.

There are two use-cases:
1. I'm a QT engineer and I'm trying to green the QT bots.
2. I just committed a patch and I'm trying to rebaseline my test on all platforms where it fails.

For case 1, splitting it up by platform is clearly better. For case 2, you actually want a unified view across all platforms (i.e. not even split by master).

Now that I've written all this out, I think we should split by platform for now. If we want a grand unified view, we can add UI for that later.

> There are probably also some assumptions in the code about the layout of URLs on build.chromium.org that we'd need to generalize.

If I were doing this, I'd do the following set of patches:
1. Adding a drop-down in the top-right corner of garden-o-matic to choose your platform and then add a builders.js file for QT (we can add Apple and GTK later when all the kinks are worked out).
2. Fix all the garden-o-matic JS code that uses build.chromium.org to use build.webkit.org for non-chromium platforms. Off the top of my head, the only things that need to change are the paths to the expected/actual results and the "master" query parameter passed to test-results.appspot.com (ChromiumWebkit --> webkit.org).
3. Fix webkit-patch rebaseline-test to do the right thing for non-Chromium bots. I think this is just making it grab actual results off build.webkit.org instead of build.chromium.org.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.