[Webkit-unassigned] [Bug 82728] Split remaining CSSRules into internal and CSSOM types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82728





--- Comment #8 from Andreas Kling <kling at webkit.org>  2012-03-30 08:21:48 PST ---
(From update of attachment 134814)
View in context: https://bugs.webkit.org/attachment.cgi?id=134814&action=review

Dumping IRC whine for posterity.

> Source/WebCore/bindings/js/JSDOMBinding.h:204
>      inline void* root(StyleSheet* styleSheet)
>      {
> +        if (styleSheet->ownerNode())
> +            return root(styleSheet->ownerNode());
> +        return styleSheet;
> +    }

This looks like it will do the wrong thing if the StyleSheet* passed points to a CSSStyleSheet object.

> Source/WebCore/css/StyleRule.h:56
> +    bool isKeyframeRule() const { return false; }

This should be removed. Calling it would indicate a bug, as it can only ever return false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.