[Webkit-unassigned] [Bug 82728] Split remaining CSSRules into internal and CSSOM types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82728





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-03-30 07:42:43 PST ---
Attachment 134814 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.xcodeproj/project.p..." exit_code: 1
Source/WebCore/css/CSSParser.h:259:  The parameter name "marginBox" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSFontSelector.cpp:48:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/StyleRule.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/StyleRule.h:109:  The parameter name "properties" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/WebKitCSSKeyframesRule.h:74:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSheet.h:147:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSheet.cpp:120:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/css/CSSStyleSheet.cpp:126:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:203:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/css/CSSStyleSheet.cpp:232:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/css/CSSStyleSheet.cpp:302:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 11 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.