[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #41 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-30 03:45:49 PST ---
(In reply to comment #40)
> (In reply to comment #37)
> 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:82
> > > +    bool fullScreenEnabled;
> > 
> > enabled sounds like you allow to run fullscreen, rather than the view is currently running fullscreen. I would use something like runningFullscreen or something like that.
> > 
> 
> If I wanted to make it sound as I allowed the view to run fullscreen I'd have named the variable fullScreenAllowed :)
> 
> My (probably very) personal understanding of fullScreenEnabled is that a webview display can be toggled between full screen and "normal windowed" states.
> 
> I'm not sure I like the "running" part of runningFullscreen. I'll leave that name as it is for now, naming variables is sometimes hard! Maybe Martin would have a good suggestion as well?

Sure, it was just a suggestion, It sounds to me like a setting that you can enable/disable, but it's also my personal understanding, so if enable/disable sounds good to you it's perfectly fine for me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.