[Webkit-unassigned] [Bug 82484] [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82484





--- Comment #3 from Sergio Villar Senin <svillar at igalia.com>  2012-03-30 01:55:55 PST ---
(In reply to comment #2)
> Created an attachment (id=134692)
 --> (https://bugs.webkit.org/attachment.cgi?id=134692&action=review) [details]
> libsoup patch to fix fast/encoding/percent-escaping
> 
> Can you try this patch against libsoup? It definitely fixes the percent-escaping test, but I seem to get lots of other differences in the test output (mostly in -stderr.txt files) as well, but I can't be sure if that's because of an actual behavior change, or just random trying-to-run-tests-on-a-non-blessed-machine flakiness.

It fixes that one indeed but the other two are still failing.

Wouldn't it be simpler just to back to soup_uri_decode()/g_file_new_for_path() and put the windows code inside some guards? Yeah I know it isn't very beautiful and that libsoup code does not have things like that, but if the glib implementations behave in a different way ... I mention that because I asked the author of the commit and he kind of remembers some issues with slashes when using g_file_new_for_path(), that's why he switched to g_file_new_for_uri().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.