[Webkit-unassigned] [Bug 82591] [EFL] LayoutTestController needs implementation of isPageBoxVisible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82591





--- Comment #2 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-03-29 13:10:40 PST ---
(From update of attachment 134539)
View in context: https://bugs.webkit.org/attachment.cgi?id=134539&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:124
> +    WebCore::Frame* frame = EWKPrivate::coreFrame(ewkFrame);

Nitpick: could be const.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:129
> +    return frame->document()->isPageBoxVisible(pageIndex);

Are you guaranteed to always have a valid Document?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.