[Webkit-unassigned] [Bug 82627] Mac should not use a text_expectations file until it is ready to fully move over to it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82627


Jessie Berlin <jberlin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jberlin at webkit.org
         Depends on|                            |38756




--- Comment #3 from Jessie Berlin <jberlin at webkit.org>  2012-03-29 11:11:35 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > The combination of Skipped / text_expectation files that is being used by NRWT on Mac is
> > 
> > 1. Confusing. Should something go on the Skipped list or in the text_expectations file?
> 
> test_expectations.txt is useful when some failure happens only in release or debug.

Which is why it is definitely something we want to move to in the future.

> 
> > 2. More places to look to figure out why some test is or isn't running, is or isn't expected to fail, etc.
> 
> We should just merge Skipped and test_expectations. test_expectations already support SKIP keyword but it's redundant because we can default to skip tests when there are no modifiers.

This definitely should be done in the future in one step (probably as part of this bug), when our concerns about Windows and WK2 are addressed.

> 
> > 3. Difficult to deal with when it comes to WK2 and Windows. NRWT doesn't work on Apple Win yet. That means that everything that we want Skipped for WK2 already has to go in the Skipped list.
> 
> Maybe we just need WK2 modifier?

I don't see how that helps the WK2 on Windows case. Even if we had a WK2 modifier in test_expectations for Mac, we would have to add all tests failing on WK2 to the WK2 Skipped list to deal with Windows.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.