[Webkit-unassigned] [Bug 80135] [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80135


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134575|review?                     |review-
               Flag|                            |




--- Comment #10 from Rob Buis <rwlbuis at gmail.com>  2012-03-29 07:20:58 PST ---
(From update of attachment 134575)
View in context: https://bugs.webkit.org/attachment.cgi?id=134575&action=review

Still some issues :)

> Source/WebCore/ChangeLog:5
> +        RIM PR: 145660

It is better to put this below the Reviewed By line. In fact cq+ might not work if it is strict about the format.

> Source/WebCore/ChangeLog:9
> +        Fixed a regression introduced by last patch to fix this PR (r111810), we should

Better rephrase:

Fixed a regression introduced by r111810, we should

> Source/WebCore/ChangeLog:13
> +        No new tests.

Why no new tests?

> Source/WebKit/blackberry/ChangeLog:9
> +        Fixed a regression introduced by last patch to fix this PR (r111810), which

Same as above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.