[Webkit-unassigned] [Bug 81221] Expose attack, release as DynamicsCompressorNode's attributes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81221





--- Comment #23 from Chris Rogers <crogers at google.com>  2012-03-28 18:09:21 PST ---
(In reply to comment #22)
> (In reply to comment #21)
> > readonly attribute [ImplementedAs=releaseTime] AudioParam release; // in Seconds
> > 
> > You can see in the patch in DynamicsCompressorNode.h that the method is called releaseTime():
> > AudioParam* releaseTime() { return m_release.get(); }
> > 
> > The mac port (EWS bot) still seems unhappy?
> 
> Ah, maybe the problem is not the method name in WebCore but the method name in ObjC-generated code. [ImplementedAs] just changes the method name in WebCore (e.g. release -> releaseTime), and it doesn't change the method name in ObjC-generated code. Specifically,
> 
>  680 - (int)strawberry
>  681{
>  682    WebCore::JSMainThreadNullState state;
>  683    return IMPL->blueberry();
>  684}
> 
> should be (int)getStrawberry or something like that, to avoid name conflict.
> 
> BTW, do you want release() in ObjC? If not, the simplest approach is just to skip generating code for release() in CodeGeneratorObjC.pm. (There are already a lot of attributes/methods that are skipped in ObjC.)

Kentaro, thanks for the answer.  I guess we don't need an ObjC binding for this.  How can I skip generating code for release in the IDL file?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.