[Webkit-unassigned] [Bug 81326] Vertical flow support for OpenType fonts with the least platform dependencies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81326


Koji Ishii <kojiishi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133975|0                           |1
        is obsolete|                            |




--- Comment #12 from Koji Ishii <kojiishi at gmail.com>  2012-03-28 14:03:35 PST ---
Created an attachment (id=134390)
 --> (https://bugs.webkit.org/attachment.cgi?id=134390&action=review)
OpenTypeVerticalData class and its related changes after mitz's 2nd review

Thank you so much for taking time for the review again.

I now understand what to do with the namespace, sorry for my misunderstanding. I've made OpenType as nested namesapce in WebCore, and also removed all OT prefixes except the macro.

Note that I use OpenType:: specifiers even when unnecessary because type names such as "Int16" looked too common to me. Please let me know if this is annoying.

Also thank you for finding the out-of-bounds reads. They were all fixed now. I added validatedPtr function to get a pointer only when size is valid. It can make sure that type names of reinterpret_cast and sizeof are the same.

I also re-reviewed by myself to see if any other oob reads are left but I didn't find any others.

Hope this be the last review. I'll r? once EWS passed just in case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.