[Webkit-unassigned] [Bug 82448] [GTK] generate-gtk-doc doesn't cope with custom build directory

Wed Mar 28 09:07:00 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=82448

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134299|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2012-03-28 09:07:00 PST ---
(From update of attachment 134299)
View in context: https://bugs.webkit.org/attachment.cgi?id=134299&action=review

>> Tools/gtk/common.py:-40
>> -        return build_dir
> 
> Why do you no longer cache the build directory here?

I cannot see a reason why it isn't. The patch looks great, but I think caching the build directory was a nice feature in that it avoided touching the file system every time you needed the build directory. Perhaps you could restore that before landing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.