[Webkit-unassigned] [Bug 82448] [GTK] generate-gtk-doc doesn't cope with custom build directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82448


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134263|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2012-03-28 07:56:59 PST ---
(From update of attachment 134263)
View in context: https://bugs.webkit.org/attachment.cgi?id=134263&action=review

> Tools/gtk/generate-gtkdoc:-123
> +    build_directory = sys.argv[-1]
>      options = get_common_options().copy()
>      options.update({
>          'module_name' : 'webkitgtk',
>          'doc_dir' : src_path('docs'),
> -        'output_dir' : common.build_path('Documentation', 'webkitgtk'),

This looks like it will pass something crazy (like the command name) if you don't pass an argument for build directory. I think I'd like to keep the logic for understanding the command-line arguments in common.build_path instead of forcing all the code here to pass the build_directory down. 

in common.get_build_path() you could do this:

def get_build_path():
    if len(sys.argv) > 1 and os.path.exists(sys.argv[-1]):
        # Try to use this path as a build directory.

With that change you could avoid all the modifications to this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.