[Webkit-unassigned] [Bug 82446] [EFL] LayoutTestController needs implementation of addUserStyleSheet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82446





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-03-28 04:34:34 PST ---
(From update of attachment 134259)
View in context: https://bugs.webkit.org/attachment.cgi?id=134259&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:68
> +    static void addUserStyleSheet(Evas_Object* ewkView, const char* sourceCode, bool allFrames);

In my humble opinion, it is better to add const keyword in front of Evas_Object. Because EWKPrivate::corePage is defined as below,
http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_private.h#L95

In addition, you just use page object without ewkView's change. It seems you can add const keyword.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.