[Webkit-unassigned] [Bug 82442] Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82442





--- Comment #4 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2012-03-28 04:17:18 PST ---
(In reply to comment #3)
> (In reply to comment #1)
> > Attaching proposed patch. This will test if any test case failures.
> 
> If no existing tests are affected, maybe we want to add test cases for this.

Currently there is already a test case http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/user-preferred-language.html?rev=105315#L20  which checks for empty vector but this wont fail even if we remove 

if (languages.isEmpty())
  return jsNull(); 

Because all the platform have the implementation for platformLanguages().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.